[v12.x] build: build benchmark addons like test addons#30072
Closed
gabrielschulhof wants to merge 1 commit intonodejs:v12.x-stagingfrom
Closed
[v12.x] build: build benchmark addons like test addons#30072gabrielschulhof wants to merge 1 commit intonodejs:v12.x-stagingfrom
gabrielschulhof wants to merge 1 commit intonodejs:v12.x-stagingfrom
Conversation
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: nodejs#29995 Fixes: nodejs/build#1961 Refs: nodejs@53ca0b9#commitcomment-35494896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-github-bot
added
build
Contributor
Author
|
This is identical to the version in master, except it does not add benchmark/napi/ref/.gitignore. |
3 tasks
richardlau
approved these changes
Oct 22, 2019
BethGriggs
approved these changes
Oct 23, 2019
gengjiawen
approved these changes
Oct 23, 2019
Member
|
The original commit landed on v12.x-staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the addons for benchmarks in the same way that the addons for
tests are built.
PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: @addaleax
Reviewed-By: @Trott
Reviewed-By: @BethGriggs
Reviewed-By: @gengjiawen
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesWe need this PR along with #30070 because 53ca0b9#commitcomment-35494896